Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choices decouple #472

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Choices decouple #472

wants to merge 3 commits into from

Conversation

goodmami
Copy link
Member

@goodmami goodmami commented Jun 9, 2020

This pull request is a work-in-progress to remove the dynamic operations on choices files so they are more like static resources. Completing this will make it possible to swap in a different format for choices files.

As the PR is not yet complete, do not merge it yet. I created it to more easily see the diffs with the master branch.

goodmami added 3 commits June 9, 2020 09:16
It was the only library that was using the full_keys() method on
choices, and in all cases it wasn't necessary.
- ChoiceCategory.full_keys()
- ChoicesFile.__eq__()
@goodmami goodmami changed the base branch from master to trunk June 19, 2020 00:57
@goodmami goodmami marked this pull request as draft June 19, 2020 00:58
@goodmami goodmami changed the title (do not merge) Choices decouple Choices decouple Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant