Quote all the things

dellis1972 · Oct 13, 2024 · 96421fa · 96421fa
1 parent 521140b
commit 96421fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/MonoGame.Framework.Content.Pipeline/ExternalTool.cs b/MonoGame.Framework.Content.Pipeline/ExternalTool.cs
@@ -99,7 +99,7 @@ public static int Run(string command, string arguments, out string stdout, out s
                 CreateNoWindow = true,
                 WindowStyle = ProcessWindowStyle.Hidden,
                 ErrorDialog = false,
-                FileName = fullPath,
+                FileName = $"\"{fullPath}\"",
                 UseShellExecute = false,
                 RedirectStandardOutput = true,
                 RedirectStandardError = true,

diff --git a/Tools/MonoGame.Content.Builder.Editor/Common/Util.cs b/Tools/MonoGame.Content.Builder.Editor/Common/Util.cs
@@ -65,13 +65,13 @@ public static Process CreateProcess(string command, string arguments, string wor
             if (command.EndsWith (".dll")) {
                 // we are referencing the dll directly. We need to call dotnet to host.
                 exe = Global.Unix ? "dotnet" : "dotnet.exe";
-                args = $"{command} {arguments}";
+                args = $"\"{command}\" {arguments}";
             }
             var _buildProcess = new Process
             {
                 StartInfo = new ProcessStartInfo
                 {
-                    FileName = exe,
+                    FileName = $"\"{exe}\"",
                     Arguments = args,
                     WorkingDirectory = workingDirectory,
                     CreateNoWindow = true,

diff --git a/Tools/MonoGame.Tools.Tests/BuilderTargetsTest.cs b/Tools/MonoGame.Tools.Tests/BuilderTargetsTest.cs
@@ -72,11 +72,11 @@ public void BuildSimpleProject()
                 Directory.Delete(outputPath, recursive: true);
 
             var result = RunBuild("dotnet", Path.Combine(root, "Assets", "Projects", "BuildSimpleProject.csproj"), new string[] {
-                "-p:MGCBCommand=" + Path.Combine(root, "mgcb.dll")
+                $"-p:MGCBCommand=\"{Path.Combine(root, "mgcb.dll")}\""
             });
             Assert.AreEqual(true, result, "Content Build should have succeeded.");
             var contentFont = Path.Combine(outputPath, "DesktopGL", "Content", "ContentFont.xnb");
-            Assert.IsTrue(File.Exists(contentFont), "'" + contentFont + "' should exist.");
+            Assert.IsTrue(File.Exists(contentFont), $"'{contentFont}' should exist.");
         }
     }
 }