Feat: New function strategy #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caller sets the callee variables. Callee returns in r0 register.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function variables are globally assigned, due to the fact there is no good way to interact with Signum User Stack. Actually only pushing and popping possible, and for a good use of it, it would be needed to set/read values from the stack without needing to removing them.
That said, there was no meaning to push and pop values if they are always assigned to the same variable, so this new strategy saves instructions cycles and in most of cases removes all stack operations. Without stack operations, the contracts can save one page of 'User Stack Page' on deployment, and also cost a little less for the execution.
The implementation continues to use stack if there is a recursive function, or if we need to save the registers from caller.
Dozens tests and also some simulations for the edge cases proves this is a good move.