This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
deps: depend only on the required lodash methods #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool that we are going with lodash 3, as for using separate modules instead of just "lodash" I am not sure this is better since the dependency tree is even bigger when you do this. cc @feross |
|
I'm not sure which approach is best, now that lodash@3 has no dependencies. Seperate modules means less KB of code, and it's easier to replace each function with another one if we need to in the future. |
|
Merged the normal lodash upgrade |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of depending on
lodashdirectly we can depend only on the required utilities as suggested in #255 (comment).Tests seem to pass but I don't know if they cover all the sensible parts.