Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shared package & remove samples #2

Merged
merged 4 commits into from
Oct 7, 2024
Merged

feat: shared package & remove samples #2

merged 4 commits into from
Oct 7, 2024

Conversation

0xkenj1
Copy link
Collaborator

@0xkenj1 0xkenj1 commented Oct 7, 2024

🤖 Linear

Closes GIT-72

Description

Base shared package with events structure and removed samples

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

Copy link

linear bot commented Oct 7, 2024

GIT-72 Shared

Copy link
Collaborator

@jahabeebs jahabeebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏻

timestamp: number;
};

export type AllocatedWithTokenParams = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: if we're going to have a lot of these eventually we can extract contractAddress into a base param like

export type RegisteredParams = BaseParams;

export type TimestampsUpdatedParams = BaseParams & {
    timestamp: number;
};

export type AllocatedWithTokenParams = BaseParams & {
    tokenAddress: Address;
    amount: number;
};

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, but all the event signatures seems to be quite different, in case we found a base pattern will do it. Thanks for this feedback :)

@0xkenj1 0xkenj1 merged commit e7544bc into dev Oct 7, 2024
6 checks passed
@0xkenj1 0xkenj1 deleted the feat/shared branch October 7, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants