Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allo pool created type #15

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix: allo pool created type #15

merged 3 commits into from
Oct 23, 2024

Conversation

0xnigir1
Copy link
Collaborator

@0xnigir1 0xnigir1 commented Oct 23, 2024

🤖 Linear

Closes GIT-112

Description

  • fix PoolCreatedParams typing
  • move strategyId field to ProtocolEvent

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

Copy link

linear bot commented Oct 23, 2024

GIT-112 Fix AlloEvent and PoolCreated params typing

Add strategyId field to ProtocolEvent and fix PoolCreatesParams type

0xkenj1
0xkenj1 previously approved these changes Oct 23, 2024
Copy link
Collaborator

@0xkenj1 0xkenj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@0xnigir1 0xnigir1 merged commit 36e26eb into dev Oct 23, 2024
6 checks passed
@0xnigir1 0xnigir1 deleted the fix/allo-event-type branch October 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants