feat: l2 metrics service #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
previously approved these changes
Sep 3, 2024
Comment on lines
+128
to
+143
| describe("getL1BatchBlockRange", () => { | ||
| it("should return the block range for the specified L1 batch number", async () => { | ||
| zkProvider = new ZKChainProvider(defaultRpcUrls, mockLogger, defaultMockChain); | ||
| const l1BatchNumber = 1000; | ||
| const blockRange: [number, number] = [5000, 6000]; | ||
|
|
||
| vi.spyOn(zkProvider["zkClient"], "getL1BatchBlockRange").mockResolvedValue(blockRange); | ||
|
|
||
| const result = await zkProvider.getL1BatchBlockRange(l1BatchNumber); | ||
|
|
||
| expect(result).toEqual(blockRange); | ||
| expect(zkProvider["zkClient"].getL1BatchBlockRange).toHaveBeenCalledWith({ | ||
| l1BatchNumber, | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Any non-happy paths worth testing?
0xkenj1
reviewed
Sep 3, 2024
| } else if (isNativeError(error)) { | ||
| this.logger.error(error); | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
Following the way we are handling errors, for the rest of the methods. Should we throw here instead of returning undefined ? The lastVerifiedBlock is not an optional method on the front end
There was a problem hiding this comment.
this got me thinking tbh, should we actually return return value | undefined for all methods? like an error on L2 shouldn't break anything as it's like not having rpc urls wdyt?
0xkenj1
previously approved these changes
Sep 3, 2024
|
as discussed offline @0xkenj1, we let the service consumer handle errors instead of returning undefined for consistency |
0xyaco
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-228
Description
L2MetricsServiceimplementation onmetricspackage