feat: ecosystem configuration #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
previously approved these changes
Aug 29, 2024
| @@ -23,6 +23,7 @@ const baseSchema = z.object({ | |||
| BRIDGE_HUB_ADDRESS: addressSchema, | |||
| SHARED_BRIDGE_ADDRESS: addressSchema, | |||
| STATE_MANAGER_ADDRESSES: addressArraySchema, | |||
| ENVIRONMENT: z.enum(["mainnet", "testnet", "local"]).default("mainnet"), | |||
There was a problem hiding this comment.
Might want to indicate that mainnet is the default somewhere in the docs? (.env.example, README, etc)
There was a problem hiding this comment.
will do it in another PR where I attack all documentation and read me detailed 🫡
0xkenj1
reviewed
Aug 30, 2024
apps/api/src/common/config/index.ts
Outdated
Comment on lines
80
to
90
| const getL2Chain = (environment: "mainnet" | "testnet" | "local") => { | ||
| switch (environment) { | ||
| case "mainnet": | ||
| return zksync; | ||
| case "testnet": | ||
| return zksyncSepoliaTestnet; | ||
| case "local": | ||
| return zksyncLocalNode; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
lets remove this function, since its not what we want as we talked offline :)
0xkenj1
approved these changes
Aug 30, 2024
0xyaco
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-211
Description
DummyPricingProvider(jic)PricingProviderFactoryENVIRONMENTvariable to switch between mainnet, testnet or local