Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: token chain json examples #59

Merged
merged 3 commits into from
Aug 29, 2024
Merged

feat: token chain json examples #59

merged 3 commits into from
Aug 29, 2024

Conversation

0xnigir1
Copy link
Collaborator

@0xnigir1 0xnigir1 commented Aug 29, 2024 •
edited
Loading

🤖 Linear

Closes ZKS-215

Description

  • Update token list with a more exhaustive one based on L2Beat list
  • Remove coingeckoId from Token
  • Add condition if SharedBridge does not have balance of token, token it's not returned in TVL
  • Update docs and examples
  • Metadata uploaded to: https://github.com/defi-wonderland/ZKchainHub-metadata

@0xnigir1 0xnigir1 requested review from 0xkenj1 and 0xyaco August 29, 2024 00:31
@linear Linear
Copy link

linear bot commented Aug 29, 2024

ZKS-215 Upload metadata to a github repository

0xkenj1
0xkenj1 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@0xkenj1 0xkenj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@0xnigir1 0xnigir1 merged commit 6a9a61a into dev Aug 29, 2024
6 checks passed
@0xnigir1 0xnigir1 deleted the feat/token-chain-json-examples branch August 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xyaco 0xyaco 0xyaco approved these changes

@0xkenj1 0xkenj1 0xkenj1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnigir1 @0xkenj1 @0xyaco