feat: base caching #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
approved these changes
Aug 22, 2024
| @@ -1,11 +1,11 @@ | |||
| import { inspect } from "util"; | |||
| import { caching } from "cache-manager"; | |||
|
|
|||
| import { EvmProvider } from "@zkchainhub/chain-providers/dist/src/index.js"; | |||
There was a problem hiding this comment.
Suggested change
| import { EvmProvider } from "@zkchainhub/chain-providers/dist/src/index.js"; | |
| import { EvmProvider } from "@zkchainhub/chain-providers"; |
| @@ -1,6 +1,7 @@ | |||
| import { Address, encodeFunctionData, erc20Abi, parseEther, zeroAddress } from "viem"; | |||
| import { afterEach, describe, expect, it, Mocked, vi } from "vitest"; | |||
|
|
|||
| import { EvmProvider, MulticallNotFound } from "@zkchainhub/chain-providers/dist/src/index.js"; | |||
There was a problem hiding this comment.
Suggested change
| import { EvmProvider, MulticallNotFound } from "@zkchainhub/chain-providers/dist/src/index.js"; | |
| import { EvmProvider, MulticallNotFound } from "@zkchainhub/chain-providers"; |
| import { NextFunction, Request, Response } from "express"; | ||
| import NodeCache from "node-cache"; | ||
|
|
||
| const DEFAULT_TTL = 60; // 1 minute |
There was a problem hiding this comment.
should we add this as env config too? maybe add it to tech debt to not forget
0xyaco
reviewed
Aug 23, 2024
|
|
||
| res.json = (body): Response => { | ||
| // Cache the response body | ||
| cache.set(key, body, args.ttl); |
There was a problem hiding this comment.
Do NodeCache instances have some kind of limit on how many items it can cache? I understand this is a v0.1 solution so no worries if you've taken into account this potentially growing a lot.
There was a problem hiding this comment.
this is just a temporary solution, no idea how many items can NodeCache handle. In this case we are just gona have 2 items.
0xyaco
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-208 Closes ZKS-199
Description
ecosystemandzkchainendpointsWe decided to move forward with
NodeCachesincecacheableby nature uses Promises so hit the cache, this causes some problems when trying to overrideres.jsonhook on express sinceres.jsonis considered sync.For next steps we will:
cacheablefor modules advanced cachingcacheablefor the cacheMiddleware