Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metadata package scaffold #52

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: metadata package scaffold #52

merged 1 commit into from
Aug 22, 2024

Conversation

0xnigir1
Copy link
Collaborator

@0xnigir1 0xnigir1 commented Aug 21, 2024

🤖 Linear

Closes ZKS-198

Description

  • Scaffold Metadata package
  • Add IMetadataService interface
  • Implement StaticMetadataService
  • Skeleton for GithubMetadataService

@0xnigir1 0xnigir1 requested review from 0xkenj1 and 0xyaco August 21, 2024 21:49
Copy link

linear bot commented Aug 21, 2024

ZKS-173 Metadata Service

Copy link

linear bot commented Aug 22, 2024

Copy link
Collaborator

@0xkenj1 0xkenj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve this one as it is and lets fix naming convention for providers and services in another pr :)

@0xnigir1 0xnigir1 merged commit b7d67af into dev Aug 22, 2024
6 checks passed
@0xnigir1 0xnigir1 deleted the feat/metadata-package branch August 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants