feat: batch request contract for fetching multiple token balance #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZKS-75 L1 TVL
Create a Batch contract to query token balances from Get the top 30 list of token addresses and tickers by USD holdings on shared bridge from etherscan. Measure how many token balance request can be made until fail or revert.
and validate boundaries BridgeHub address: 0x303a465B659cBB0ab36eE643eA362c509EEb5213 SharedBridge address: 0xD7f9f54194C633F36CCD5F3da84ad4a1c38cB2cB AC:
|
wei3erHase
reviewed
Aug 1, 2024
contracts/test/TokenBalances.t.sol
Outdated
Comment on lines
34
to
38
| // We're using vm.etch to place the creation code at a deterministic address. | ||
| vm.etch(_deploymentAddress, creationCode); | ||
|
|
||
| // simulate deployment | ||
| (bool success, bytes memory result) = _deploymentAddress.call(""); |
There was a problem hiding this comment.
Claude-AI gave me a hand jaja 😅
wei3erHase
reviewed
Aug 1, 2024
contracts/test/TokenBalances.t.sol
Outdated
Comment on lines
52
to
53
| vm.mockCall(address(_tokenA), abi.encodeWithSelector(IERC20.balanceOf.selector), abi.encode(_initialBalanceA)); | ||
| vm.mockCall(address(_tokenB), abi.encodeWithSelector(IERC20.balanceOf.selector), abi.encode(_initialBalanceB)); |
wei3erHase
reviewed
Aug 1, 2024
contracts/test/TokenBalances.t.sol
Outdated
| tokenAddresses[0] = address(_tokenA); | ||
| tokenAddresses[1] = address(_tokenB); | ||
|
|
||
| bytes memory creationCode = getBytecode(_target, tokenAddresses); |
There was a problem hiding this comment.
there's another one like this..
Suggested change
| bytes memory creationCode = getBytecode(_target, tokenAddresses); | |
| bytes memory creationCode = _getBytecode(_target, tokenAddresses); |
ZKS-138 Batch Contract implementation
Create a Batch contract to query token balances from Use Foundry for testing the contract |
0xyaco
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-138
Description