Merge remote-tracking branch 'origin/dev' into fix/handle-dispute-esc…

…alated
defi-wonderland · Nov 1, 2024 · 4ab85a4 · 4ab85a4
2 parents a43b62d + 42ee7c4
commit 4ab85a4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/packages/automated-dispute/src/services/eboActor.ts b/packages/automated-dispute/src/services/eboActor.ts
@@ -159,7 +159,12 @@ export class EboActor {
                 } catch (err) {
                     if (err instanceof ProphetDecodingError) {
                         // Skipping malformed entities
-                        this.logger.warn(err.message);
+                        this.logger.warn(
+                            stringify({
+                                reason: err.err?.name,
+                                message: err.message,
+                            }),
+                        );
 
                         continue;
                     } else {

diff --git a/packages/automated-dispute/src/services/prophetCodec.ts b/packages/automated-dispute/src/services/prophetCodec.ts
@@ -237,18 +237,10 @@ export class ProphetCodec {
      * @returns The DisputeStatus string corresponding to the input value.
      */
     static decodeDisputeStatus(status: number): DisputeStatus {
-        try {
-            const disputeStatus = DISPUTE_STATUS_ENUM[status];
+        const disputeStatus: DisputeStatus | undefined = DISPUTE_STATUS_ENUM[status];
 
-            if (!disputeStatus) throw new ProphetDecodingError("dispute.status", toHex(status));
-            else return disputeStatus;
-        } catch (err) {
-            throw new ProphetDecodingError(
-                "dispute.status",
-                toHex(status.toString()),
-                err instanceof Error ? err : undefined,
-            );
-        }
+        if (disputeStatus) return disputeStatus;
+        else throw new ProphetDecodingError("dispute.status", toHex(status.toString()));
     }
 
     /**