Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed constraints on dependency versions in requirements.txt #691

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

julian-risch
Copy link
Member

The pinned version requirements are now more relaxed to prevent users from running into dependency conflicts when using FARM as one component within larger projects.

seqeval, dotmap
Removed the fixed version numbers. All tests passed with the different available versions of these libraries and I checked for a selection of the examples that they run as expected.

mlflow
Restricted the version to the latest available version 1.13.1 or lower. All tests passed and the logging works for the examples as expected for the different available versions of mlflow. The restriction ensures that any breaking changes in future versions of mlflow will not affect us.

Werkzeug
Kept the version as is because there are still compatibility issues with the more recent versions (>=1.0.0) as reported earlier: #250 Some smaller code changes would be needed if we decide to upgrade. For now, the best practice seems to be pinning the version number as is, e.g.: jarus/flask-testing#143

closes #669
closes #647

@julian-risch julian-risch requested a review from tholor January 19, 2021 14:36
@Timoeller Timoeller requested review from Timoeller and removed request for tholor January 19, 2021 16:23
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

Thanks for also testing examples - especially for mlflow this was necessary.

@Timoeller Timoeller merged commit 9b7dbc8 into master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fixed version from requirements as much as possible Dependency conflict with latest mlflow
2 participants