[serving] Improve logging for exec shell command #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Raising PR on behalf of Frank. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
frankfliu
approved these changes
Nov 17, 2024
siddvenk
reviewed
Nov 18, 2024
| @@ -54,6 +52,21 @@ public final class LmiUtils { | |||
|
|
|||
| private LmiUtils() {} | |||
|
|
|||
| static void exec(List<String> cmd) throws IOException, InterruptedException { | |||
There was a problem hiding this comment.
Not needed in this PR - we can do this as a follow up, but might be nice to put this into a generic ProcessUtils class or something similar. We have a few more places where we do this (like cluster request handler)
There was a problem hiding this comment.
We can make this in ProcessUtils class, but need to make error checking more generic, this class currently has logic specific for s3cmd:
logOutput.startsWith("ERROR ")
We can pass a regex if caller need extra error checking:
(regex != null && logOutput.matches(regex))
| } | ||
| int exitCode = exec.waitFor(); | ||
| if (0 != exitCode || logOutput.startsWith("ERROR ")) { | ||
| logger.info("{}", logOutput); |
There was a problem hiding this comment.
should this be logged at error level?
siddvenk
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Improve logging for exec shell command