Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-6.6.y] Add MWAIT Cx support for Zhaoxin CPUs #267

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

leoliu-oc
Copy link
Contributor

zhaoxin inclusion
category: bugfix
CVE: NA


When the processor is idle,low-power idle states (C-states) can be used to save power. For Zhaoxin processors,there are two methods to enter idle states. One is HLT instruction and legacy method of I/O reads from the ACPI-defined register (known as P_LVLx),the other one is MWAIT instruction with idle states hints.

Default for legacy operating system,HLT and P_LVLx I/O reads are used for Zhaoxin Processors to enter idle states, but we have checked on some Zhaoxin platform that MWAIT instruction is more efficient than P_LVLx I/O reads and HLT, so we add MWAIT Cx support for Zhaoxin Processors.

zhaoxin inclusion
category: bugfix
CVE: NA

-----------------

When the processor is idle,low-power idle states (C-states) can be used
to save power. For Zhaoxin processors,there are two methods to enter idle
states. One is HLT instruction and legacy method of I/O reads from the
ACPI-defined register (known as P_LVLx),the other one is MWAIT
instruction with idle states hints.

Default for legacy operating system,HLT and P_LVLx I/O reads are used for
Zhaoxin Processors to enter idle states, but we have checked on some
Zhaoxin platform that MWAIT instruction is more efficient than P_LVLx I/O
reads and HLT, so we add MWAIT Cx support for Zhaoxin Processors.

Signed-off-by: leoliu-oc <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leoliu-oc leoliu-oc changed the title Add MWAIT Cx support for Zhaoxin CPUs [linux-6.6.y] Add MWAIT Cx support for Zhaoxin CPUs Jun 13, 2024
Copy link
Member

@opsiff opsiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • arch_has_acpi_pdc函数中,新增的条件判断可能会导致逻辑错误,如果c->x86_vendor等于X86_VENDOR_CENTAURX86_VENDOR_ZHAOXIN时,应该直接返回true,而不是进行额外的条件判断。
  • ffh_cstate_init函数中,新增的条件判断c->x86_vendor != X86_VENDOR_CENTAUR && c->x86_vendor != X86_VENDOR_ZHAOXIN可能会导致原有的逻辑判断失效,需要确认新增的条件是否与原有逻辑一致。

是否建议立即修改:

@opsiff
Copy link
Member

opsiff commented Jun 13, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants