Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-6.6.y] hwmon: Add support for Zhaoxin core temperature monitoring #259

Merged

Conversation

leoliu-oc
Copy link
Contributor

zhaoxin inclusion
category: feature
CVE: NA


Add support for the temperature sensor inside CPU. Supported are all known variants of the Zhaoxin processors.

zhaoxin inclusion
category: feature
CVE: NA

-----------------

Add support for the temperature sensor inside CPU. Supported are all known
variants of the Zhaoxin processors.

Signed-off-by: leoliu-oc <[email protected]>
@deepin-ci-robot
Copy link

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@opsiff opsiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • temperature_access函数中,应该检查msr_index是否为0,如果是,则不需要写入MSR。
  • zhaoxin_cputemp_onlinezhaoxin_cputemp_down_prep函数中使用了全局变量pdev_list,这可能会导致并发访问时出现竞态条件。建议使用互斥锁来保护对pdev_list的访问。
  • zhaoxin_cputemp_init函数中,对于CONFIG_HOTPLUG_CPU的检查应该放在模块初始化之前,以便在模块未加载时也能进行错误处理。
  • zhaoxin_cputemp_exit函数中,应该先移除状态,然后再注销平台驱动。
  • rdmsr_safe_on_cpuwrmsr_safe_on_cpu函数中没有处理错误返回值,应该在调用这些函数的地方检查并处理错误。
  • zhaoxin_cputemp_driver结构体中包含了platform_drivercpuhp_state两个部分,建议将它们拆分为两个模块,以保持模块的单一职责。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opsiff
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
Copy link
Member

opsiff commented Jun 19, 2024

@Avenger-285714 x86 defconfig上需要打开配置:SENSORS_ZHAOXIN_CPUTEMP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants