Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-6.6.y] Add support for Zhaoxin Serial ATA IDE. #256

Merged

Conversation

leoliu-oc
Copy link
Contributor

zhaoxin inclusion
category: feature


With this driver, Serial ATA device can run in IDE mode on Zhaoxin CPUs.

zhaoxin inclusion
category: feature

-------------------

With this driver, Serial ATA device can run in IDE mode on Zhaoxin CPUs.

Signed-off-by: leoliu-oc <[email protected]>
@deepin-ci-robot
Copy link

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leoliu-oc leoliu-oc changed the title Add support for Zhaoxin Serial ATA IDE. [linux-6.6.y] Add support for Zhaoxin Serial ATA IDE. Jun 12, 2024
Copy link
Member

@opsiff opsiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opsiff
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit bd2edcf into deepin-community:linux-6.6.y Jun 19, 2024
2 of 4 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • zx_hardreset函数中,对pmp的检查应该在访问ata_sff_wait_ready之前进行,以确保pmp有效。
  • zx_scr_readzx_scr_write函数中,对pdev的空指针检查应该更明确,以避免潜在的未定义行为。
  • zx_configure函数中的pci_read_config_byte调用可能需要检查返回值,以确保正确设置寄存器。
  • zx_tf_load函数中,对tf的访问应该在确保tf有效之后进行,以避免潜在的未定义行为。
  • zx_prepare_host函数中的ata_slave_link_init调用可能需要检查返回值,以确保所有端口都被正确初始化。
  • zx_init_one函数中的rc变量在返回之前应该被检查,以确保不会返回无效的错误码。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants