Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intel-SIG] MTL cpufreq driver updates sync with upstream (6.9) #247

Merged

Conversation

quanxianwang
Copy link
Contributor

-- 0015

1f4b7fd,cpufreq: intel_pstate: Update default EPPs for Meteor Lake,2024-02-24 15:02:33 +0100,Srinivas Pandruvada [email protected],v6.9-rc1

-- 0015-0 dependency

240a8da,cpufreq: intel_pstate: Allow model specific EPPs,2024-02-24 15:02:33 +0100,Srinivas Pandruvada [email protected],v6.9

mainline:240a8da623008eb9f4e32c7a19ce16a6605911dc
severity: Moderate

upstream commit 240a8da ("cpufreq: intel_pstate: Allow model specific EPPs")

The current implementation allows model specific EPP override for
balanced_performance. Add feature to allow model specific EPP for all
predefined EPP strings. For example for some CPU models, even changing
performance EPP has benefits

Use a mask of EPPs as driver_data instead of just balanced_performance.

Intel-SIG: commit 240a8da ("cpufreq: intel_pstate: Allow model specific EPPs")

Signed-off-by: Srinivas Pandruvada <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
mainline:1f4b7fdd71e066aa7c01e3e26ceeb39b47dd5461
severity: Moderate

upstream commit 1f4b7fd ("cpufreq: intel_pstate: Update default EPPs for Meteor Lake")

Update default balanced_performance EPP to 115 and performance EPP to 16.

Changing the balanced_performance EPP has better performance/watt
compared to default powerup EPP value of 128.

Changing the performance EPP to 0x10 shows reduced power for similar
performance as EPP 0. On small form factor devices this is beneficial
as lower power results in lower CPU and skin temperature. This
results in reduced thermal throttling and higher performance.

Intel-SIG: commit 1f4b7fd ("cpufreq: intel_pstate: Update default EPPs for Meteor Lake")

Signed-off-by: Srinivas Pandruvada <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • intel_pstate_init函数中,x86_match_cpu函数的调用从intel_epp_balance_perf数组变更为intel_epp_default数组,需要确认这一变更是否符合设计需求。
  • intel_pstate_init函数中,对id变量的检查和赋值逻辑被修改,需要确保新的逻辑不会影响现有的功能。
  • intel_pstate_init函数中,新增了对hybrid_id的检查和赋值逻辑,也需要确保新的逻辑不会影响现有的功能。
  • intel_pstate_init函数中,新增了对epp_values数组的打印调试信息,需要确保这一改动不会影响性能和调试的稳定性。

是否建议立即修改:

  • 是,需要确保代码的变更不会引入新的错误,并且与整体设计保持一致。同时,应该进行充分的测试来验证这些更改不会对系统功能产生负面影响。

@matrix-wsk matrix-wsk merged commit 213027e into deepin-community:linux-6.6.y Jun 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants