Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: config: loongarch: use 16K pages in deepin_loongarch_desktop_config #216

Conversation

MingcongBai
Copy link
Contributor

While using 4K pages may provide better performance, this configuration will degrade compatibility with certain applications (especially those built upon Electron, i.e., Tencent QQ).

Use 16K pages instead, as most distributions currently do.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xzl01 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Collaborator

just use "git commit --signoff" plz.

@MingcongBai
Copy link
Contributor Author

just use "git commit --signoff" plz.

Oops, one sec.

…nfig

While using 4K pages may provide better performance, this configuration will
degrade compatibility with certain applications (especially those built upon
Electron, i.e., Tencent QQ).

Use 16K pages instead, as most distributions currently do.

Signed-off-by: Mingcong Bai <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/linux-6.6.y/loongarch-16k-pages branch from edbfe85 to 1b10555 Compare May 27, 2024 03:25
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 检查新增的配置项CONFIG_16KB_3LEVEL是否在平台相关文档中有说明其用途和影响
  • 确认是否有必要对CONFIG_16KB_3LEVEL的配置改动进行测试,包括兼容性和性能测试

是否建议立即修改:

  • 是,确保代码改动是有意义的,并且不会引入任何潜在的问题。

@Avenger-285714 Avenger-285714 merged commit 3424247 into deepin-community:linux-6.6.y May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants