Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) scripts: drop + from kernel localversion #196

Conversation

MingcongBai
Copy link
Contributor

We simply do not use the + suffix to denote distribution packaging.

Drop the + suffix.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MingcongBai MingcongBai changed the title chore(scripts/setlocalversion): drop + from kernel localversion (kernel-rolling) chore(scripts/setlocalversion): drop + from kernel localversion May 23, 2024
@deepin-ci-robot
Copy link

Hi @MingcongBai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

We simply do not use the + suffix to denote distribution packaging.

Drop the + suffix.
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/setlocalversion branch from 87ec157 to 60dde2c Compare May 23, 2024 10:35
@MingcongBai MingcongBai changed the title (kernel-rolling) chore(scripts/setlocalversion): drop + from kernel localversion (kernel-rolling) scripts: drop + from kernel localversion May 23, 2024
@Avenger-285714 Avenger-285714 merged commit 3f9408d into deepin-community:kernel-rolling May 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants