Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethernet: bundle module for Motorcomm YT6801 #190

Merged
merged 1 commit into from
May 23, 2024
Merged

ethernet: bundle module for Motorcomm YT6801 #190

merged 1 commit into from
May 23, 2024

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented May 22, 2024

  • The Asus XC-LS3A6M motherboard (Loongson 3A6000) comes with two Ethernet ports, which uses a yt6801 controller.
  • This patch introduces an out of tree module to provide support for this NIC. 1
  • Refactor module tree to make it work with Kconfig. 2
  • Drop unneeded installation script (yt_nic_install.sh).
  • Trim README to remove useless installation instructions.
  • enable YT6801 for x86 arm64 and loongarch as module
  • the patch is NOT success for ./scripts/checkpatch.pl

Footnotes

  1. Ref: https://www.motor-comm.com/Public/Uploads/uploadfile/files/20240104/yt6801-linux-driver-1.0.27.zip ↩

  2. CONFIG_NET_VENDOR_MOTORCOMM =(y)=> CONFIG_YT8601 (tristate). ↩

@opsiff @MingcongBai @yetist
ethernet: bundle module for Motorcomm YT6801
d304189 
- The Asus XC-LS3A6M motherboard (Loongson 3A6000) comes with two Ethernet
  ports, which uses a yt6801 controller.
- This patch introduces an out of tree module to provide support for this
  NIC. [^1]
- Refactor module tree to make it work with Kconfig. [^2]
- Drop unneeded installation script (yt_nic_install.sh).
- Trim README to remove useless installation instructions.
- enable YT6801 for x86 arm64 and loongarch as module

[^1]: Ref: https://www.motor-comm.com/Public/Uploads/uploadfile/files/20240104/yt6801-linux-driver-1.0.27.zip
[^2]: CONFIG_NET_VENDOR_MOTORCOMM =(y)=> CONFIG_YT8601 (tristate).

Co-authored-by: Mingcong Bai <[email protected]>
Co-authored-by: Xiaotian Wu <[email protected]>
Signed-off-by: Wentao Guan <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

@Avenger-285714
Copy link
Collaborator

这是一个需要备注的pr. 该驱动可以编译通过，测试可以用。但是代码风格存在大量的问题。目前需要推进deepin23 loongarch架构发布6.6内核，所有该提交先行合并。以后应另行提交修复代码风格问题。 除此之外，这是我们自己移植的提交。这不是最好的方式，应推动厂商主动向我们提交代码。如有必要，日后应revert该提交。

@Avenger-285714
Copy link
Collaborator

这是一个需要备注的pr. 该驱动可以编译通过，测试可以用。但是代码风格存在大量的问题。目前需要推进deepin23 loongarch架构发布6.6内核，所有该提交先行合并。以后应另行提交修复代码风格问题。 除此之外，这是我们自己移植的提交。这不是最好的方式，应推动厂商主动向我们提交代码。如有必要，日后应revert该提交。

cc： @opsiff @Zeno-sole

@Avenger-285714 Avenger-285714 merged commit 78c0f53 into deepin-community:linux-6.6.y May 23, 2024
2 of 3 checks passed
@MingcongBai MingcongBai mentioned this pull request May 23, 2024
Merged
@MingcongBai MingcongBai mentioned this pull request Jun 27, 2024
Closed
@MingcongBai MingcongBai mentioned this pull request Aug 20, 2024
Closed
@MingcongBai MingcongBai mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenchongbiao chenchongbiao Awaiting requested review from chenchongbiao

@tsic404 tsic404 Awaiting requested review from tsic404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opsiff @deepin-ci-robot @Avenger-285714