Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hda: phytium: Add Phytium hda driver support #187

Conversation

tianwei08222
Copy link

This patch adds the Phytium hda driver support.

This patch adds the Phytium hda driver support.

Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Tian Wei <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

This patch adds basic support for the FT4xxx HDA controller series
to the ALSA HDA driver.

It defines a new structure, struct hda_ft, which is a sub-structure
of struct hda_controller. The new structure is used to hold
information specific to the FT4xxx HDA controller.

The patch also defines a new function, hda_ft_probe, which is used
to detect and initialize the FT4xxx HDA controller. The function
is called by the ALSA HDA driver's probe_device() function.

Finally, the patch includes some defines and structures that
are used by the new functions and structures.

bool access_sdnctl_in_dword:1; /* accessing the sdnctl register by dword */
bool not_use_interrupts:1; /* prohibiting the RIRB IRQ */
bool access_sdnctl_in_dword:1; /* accessing the sdnctl register by dword */
bool cmd_resend; /* command resend */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否使用:1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以不这样,因为在azx_first_init会赋值成1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以不这样,因为在azx_first_init会赋值成1

这里的 :1 不是初始值,而是位域占用空间大小, :1 的话编译器可以看情况压缩成和其他 bool 在同一个字节里,节约内存

sound/hda/hdac_controller.c Show resolved Hide resolved
@Avenger-285714
Copy link
Collaborator

这个pr有合并冲突,先关闭了。我这边给这个补丁推送了新的提交,请各位同学们review

#312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants