Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) usb: xhci: Add XHCI_RESET_ON_RESUME quirk for Phytium #178

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 22, 2024

Picked and rebased from #128.

From original pull request:

add XHCI_RESET_ON_RESUME qurik for phytium xhci controller .for example x100 pci switch and e2000 platform ...
this patch fix usb to work ,after resume from S3.

Builds tested

  • amd64
  • arm64
  • loong64

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xzl01 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @MingcongBai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Chen Zhenhua and others added 3 commits May 29, 2024 08:41
The resume operation of Phytium Px210 xHCI host would failed
to restore state. Use the XHCI_RESET_ON_RESUME quirk to skip
it and reset the controller after resume.

Signed-off-by: Wang Zhimin <[email protected]>
Signed-off-by: Chen Zhenhua <[email protected]>
Reviewed-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
This patch documents the DT bindings for Phytium Pe220x XHCI controller.

Signed-off-by: Wang Zhimin <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Phytium Pe220x xHCI host controller does not have suspend/resume
support. Therefore, use of the XHCI_RESET_ON_RESUME quirk is
mandatory in order to avoid failures after resume.

Signed-off-by: Wang Zhimin <[email protected]>
Signed-off-by: Chen Zhenhua <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/phytium-xhci-quirk branch from a432014 to 7fc0ff4 Compare May 29, 2024 00:41
@MingcongBai
Copy link
Contributor Author

Failed to build on amd64:

drivers/usb/host/xhci-plat.c:569:40: error: ‘xhci_plat_phytium_pe220xundeclared here (not in a function)
  569 |         { "PHYT0039", (kernel_ulong_t)&xhci_plat_phytium_pe220x },                                
      |                                        ^~~~~~~~~~~~~~~~~~~~~~~~                                   
  CC [M]  drivers/gpu/drm/virtio/virtgpu_plane.o                                                          
make[8]: *** [scripts/Makefile.build:243drivers/usb/host/xhci-plat.o] 错误 1                            
  CC [M]  drivers/media/rc/keymaps/rc-dtt200u.o                                                           
make[7]: *** [scripts/Makefile.build:481drivers/usb/host] 错误 2                                        
make[7]: *** 正在等待未完成的任务....            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants