Skip to content

Commit

Permalink
scsi/linkdata: Fix flag ignored error with clang-19
Browse files Browse the repository at this point in the history
Some platforms such as 'x86_64' does not support
'-mno-outline-atomics' option, so add a compiler check before it.

Fix follow error with clang-19:
  clang: error: 'x86_64' does not support '-mno-outline-atomics'; flag ignored [-Werror,-Woption-ignored]

By the way, EXTRA_{A,C,CPP,LD}FLAGS are deprecated and should be
replaced by the new flags added via commit f77bf01 ("kbuild:
introduce ccflags-y, asflags-y and ldflags-y").

Fixes: 6572288 ("deepin: arm: scsi: fix build error of linkdata ps3stor driver")
Signed-off-by: WangYuli <[email protected]>
  • Loading branch information
Avenger-285714 committed Nov 24, 2024
1 parent 001f129 commit bde1cc2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/linkdata/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
EXTRA_CFLAGS += -DPS3_CFG_RELEASE
EXTRA_CFLAGS += -DPS3_HARDWARE_ASIC
EXTRA_CFLAGS += -DPS3_MODEL_V200
EXTRA_CFLAGS += -mno-outline-atomics

obj-$(CONFIG_SCSI_LINKDATA_PS3STOR) += ps3stor.o

Expand All @@ -21,6 +20,7 @@ ccflags-y += -I$(srctree) \
-I$(srctree)/drivers/scsi/linkdata/linux \
-I$(srctree)/drivers/scsi/linkdata/include \
-I$(srctree)/drivers/scsi/linkdata/include/htp_v200
ccflags-y += $(call cc-option, -mno-outline-atomics)

clean:
@rm -rf *.o *.d *.ko Module.* modules.* *.mod.* .*.d .*.cmd .tmp_versions *.o.ur-safe
Expand Down

0 comments on commit bde1cc2

Please sign in to comment.