Improved inference of inherited method calls (fixes issues when parent::toArray() calls in JSON resources were not working as expected with larger classes hierarchies)
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romalytvynenko
force-pushed
the
feat/improved-static-method-calls-analysis
branch
from
e05e053
to
2ca59d5
Compare
romalytvynenko
changed the title
romalytvynenko
changed the title
parent::toArray() calls in JSON resources were not working as expected with larger classes hierarchies)
romalytvynenko
changed the title
parent::toArray() calls in JSON resources were not working as expected with larger classes hierarchies)parent::toArray() calls in JSON resources were not working as expected with larger classes hierarchies)
romalytvynenko
deleted the
feat/improved-static-method-calls-analysis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves inference of inherited method calls. Now both
parent::methodName()and$obj->methodName()return types get resolved as expected.