-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper handling of union types when used as a typehints for route parameters #388
Conversation
@romalytvynenko are these changes a part of a release? I'm still getting an error due to union types. |
@cwray-tech can you confirm you still have the issue on 0.10.12? If so, please share the current code that fails. Thanks! |
@romalytvynenko No I was on v0.8.6.. Unfortunately, can't upgrade either due to a composer conflict. pestphp/pest-plugin-drift requires nikic/php-parser ^4.17.1 while this package requires greater than 5. |
@cwray-tech Yeah, |
We're using laravel 10 unfortunately. |
Do you know of any work around to fix the union types issue on our end? |
@cwray-tech Laravel 10 is supported though! I can see that pest drift required php-parser v5 as well: https://github.com/pestphp/pest-plugin-drift/blob/2.x/composer.json Any chance you can try updating both dependencies? |
@romalytvynenko I removed the package and it worked. But.. running into other issues related to our app. |
@cwray-tech let me know if you need any help! |
fixes #219
fixes #385