-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to override tag generation behaviour #323
Conversation
@WildEgo please fix failing tests |
Should be done mate, can you have a quick look? |
@WildEgo I love the idea, but I believe the default tag resolver should not affect tests at all. Can you please fix that? |
The reason it does is the following: https://swagger.io/docs/specification/grouping-operations-with-tags/ |
@WildEgo Please keep the original behavior. |
@romalytvynenko Done |
According the previous pr discussion, please rename the method to resolveTagsUsing and pass operation as second argument. Also this needs tests |
@WildEgo any update on this? |
Haven't had time to look at it yet, my current task got moved away from this currently |
@romalytvynenko Just updated it and synced it with the new stuff, it seems like it's having issues with different tests then mine for some reason, could you help me out with this? Rather confused atm tbh |
@WildEgo please give me write permission to your forked Scramble repo. Cannot help without it. |
Sorry for the delay, got u there, I'm not really used to tests so this is a bit foreign for me still |
@WildEgo still no access |
You might have to access via email, no idea why git does that but it does |
As the alternative to #282
Closes #130