Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to override tag generation behaviour #323

Merged
merged 9 commits into from
Mar 12, 2024

Conversation

WildEgo
Copy link
Contributor

@WildEgo WildEgo commented Mar 3, 2024

As the alternative to #282

Closes #130

@romalytvynenko
Copy link
Member

@WildEgo please fix failing tests

@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 3, 2024

@WildEgo please fix failing tests

Should be done mate, can you have a quick look?

@romalytvynenko
Copy link
Member

@WildEgo I love the idea, but I believe the default tag resolver should not affect tests at all. Can you please fix that?

@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 3, 2024

The reason it does is the following: https://swagger.io/docs/specification/grouping-operations-with-tags/
I can rollback that specific change but it's as the link above says

@romalytvynenko
Copy link
Member

@WildEgo Please keep the original behavior.

@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 3, 2024

@romalytvynenko Done

@romalytvynenko
Copy link
Member

According the previous pr discussion, please rename the method to resolveTagsUsing and pass operation as second argument.

Also this needs tests

@romalytvynenko
Copy link
Member

@WildEgo any update on this?

@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 8, 2024

@WildEgo any update on this?

Haven't had time to look at it yet, my current task got moved away from this currently

@romalytvynenko romalytvynenko changed the title add: Tag behaviour overriding callback. Added ability to override tag generation behaviour Mar 9, 2024
@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 12, 2024

@romalytvynenko Just updated it and synced it with the new stuff, it seems like it's having issues with different tests then mine for some reason, could you help me out with this? Rather confused atm tbh

@romalytvynenko
Copy link
Member

romalytvynenko commented Mar 12, 2024

@WildEgo please give me write permission to your forked Scramble repo. Cannot help without it.

@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 12, 2024

@WildEgo please give me write permission to your forked Scramble repo. Cannot help without it.

Sorry for the delay, got u there, I'm not really used to tests so this is a bit foreign for me still

@romalytvynenko
Copy link
Member

@WildEgo still no access

image

@WildEgo
Copy link
Contributor Author

WildEgo commented Mar 12, 2024

@WildEgo still no access

image

You might have to access via email, no idea why git does that but it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize operation tags
2 participants