Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spv: Accept cfilters from more peers. #2445

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

JoeGruffins
Copy link
Member

If initial sync takes longer than six blocks and peers have not changed, sync will hand at ninety-nine percent unable to get cfilters for the last few blocks. Also accept cfilters from a peer that gave us headers at or above the desired height in this case.

closes #2444

If initial sync takes longer than six blocks and peers have not changed,
sync will hand at ninety-nine percent unable to get cfilters for the
last few blocks. Also accept cfilters from a peer that gave us headers
at or above the desired height in this case.
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is reasonable, but I'm finding hard to believe every instance of the hang reported in #2444 is caused by 6+ blocks being mined during sync (specially now that SPV sync is much faster and in the order of < 10 minutes).

@jrick jrick merged commit 1d9f076 into decred:master Nov 4, 2024
2 checks passed
@JoeGruffins
Copy link
Member Author

Fix is reasonable, but I'm finding hard to believe every instance of the hang reported in #2444 is caused by 6+ blocks being mined during sync (specially now that SPV sync is much faster and in the order of < 10 minutes).

It takes me over 10 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spv: Sync stops at 99.9%
3 participants