vsp: Use client provided by vspd package. #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
requested changes
Mar 15, 2023
jholdstock
force-pushed
the
vspd-client2
branch
from
5c03069 to
b568079
Compare
The client provided by the vspd package is based on the one which this PR removes from dcrwallet, so there should be no significant difference in functionality. Using the vspd implementation removes a lot of hard-coded duplication which is liable to fall out of sync, e.g. error codes, req/resp types, URLs.
jholdstock
force-pushed
the
vspd-client2
branch
from
465fd05 to
93348e2
Compare
jrick
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client provided by the vspd package is based on the one which this PR removes from dcrwallet, so there should be no significant difference in functionality.
Using the vspd implementation removes a lot of hard-coded duplication which is liable to fall out of sync, e.g. error codes, req/resp types, URLs.
This currently leaves no way for dcrwallet to record request/response bytes as described in the original vspd spec, however decred/vspd#364 has been opened to implement that in future.
I backported this to 1.7 and used it with autobuyer for a couple of weeks on https://testnet-vsp.jholdstock.uk - several thousand tickets processed and no issues observed.