Skip to content

Commit

Permalink
Do not specify TLS curve preferences
Browse files Browse the repository at this point in the history
TLS 1.2 is already the required minimum TLS version, which does not support
any insecure curves.

Additionally, setting the curve preferences disables the X25519MLKEM768 key
exchange, which would otherwise be used by default beginning in Go 2.24.
  • Loading branch information
jrick committed Dec 17, 2024
1 parent 8886be1 commit a491052
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions chain/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,7 @@ func (s *Syncer) Run(ctx context.Context) (err error) {
pool := x509.NewCertPool()
pool.AppendCertsFromPEM(s.opts.CA)
tc := &tls.Config{
MinVersion: tls.VersionTLS12,
CurvePreferences: []tls.CurveID{tls.X25519, tls.CurveP256},
MinVersion: tls.VersionTLS12,
CipherSuites: []uint16{ // Only applies to TLS 1.2. TLS 1.3 ciphersuites are not configurable.
tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,
tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,
Expand Down

0 comments on commit a491052

Please sign in to comment.