Fix gossip timestamps set to a future date #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a migration that removes gossip timestamps that are in the future from the database of last received peer gossip timestamp. This fixes issues that could lead to lack of routing information when the peer wrongly sent a date in the future as the timestamp for a channel update or node announcement.
This adds some handling for gossip timestamps in the future. Previously, a wrongly configured node could send channel updates or node announcements with a timestamp in the future, and the propagation of such timestamps would cause the local node to record a time in the future as the most recent timestamp received via gossip. This would cause that, on restarts, the node would install a gossip timestamp horizon far in the future, causing it to miss channel updates and node announcements and breaking pathfinding. This fixes the immediate handling of future timestamps in the gossiper, while a future commit will fix the existing database entries with a migration. The fix in the gossiper involves disregarding future timestamps for the purposes of storing it in the db, and (for future proofing against this error happening again) not using such timestamps in case they are actually saved in the db.
dajohi
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the deployed network where nodes sending ChannelUpdates and NodeAnnouncements set to a future timestamp could cause the gossip syncer to fail to fetch new announcements.
The issue stems from the fact that the gossip syncer stores the timestamp of the last received message and uses that, upon restart, to fetch new messages. An update with a timestamp in the future propagating through the network would cause the syncer to fail to fetch new updates.
This PR fixes the issue by amending the handling of future timestamps in the syncer and by performing a database migration that rewinds any timestamps stored that are set to a future date.