multi: add support for DCR-USDT pair on /markets view
#2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR sets the foundation for adding other pairs and exchanges. As per UI, we can always improve on that if there are suggestions. If a redesign is want we want, I can get that sorted. |
- Add Mexc exchange `DCR-USDT` pair.
- Add Binance `DCR-USDT` pair.
- Fix minor bugs
Breaking Changes:
1. `ratesproto`: Rate messages are no longer `DCR-BTC` only, a new `currencyPair` field indicates which market rate is sent.
`ExchangeSubscription` field changed from `btcIndex` to `index`.
2. `exchanges`: Aggregated chart data has been removed. This is because combining usdt and btc market bids and asks is not
ideal and serves very little purpose. Each market has its own chart.
3. Renamed three fields on `exchanges.ExchangeBotState`:
- `btc_index` -> `index`
- `dcr_btc_exchanges` -> `dcr_exchanges` (this field now returns a nested map of supported markets)
- `btc_indices` -> `indices` (this field now returns a nested map of supported indices)
4. Affected API Endpoints:
- `/exchangerate` (`exchanges.ExchangeRates.Exchanges` json field returns a nested map of support markets)
- `/exchanges` (returns modified `exchanges.ExchangeBotState`)
Signed-off-by: Philemon Ukane <[email protected]>
ukane-philemon
force-pushed
the
dcr-usdt
branch
from
96d80c1 to
ffce1c6
Compare
Signed-off-by: Philemon Ukane <[email protected]>
ukane-philemon
force-pushed
the
dcr-usdt
branch
from
ffce1c6 to
fb33fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCR-USDTpair.DCR-USDTpair.Breaking Changes:
Closes #2001