[DO NOT MERGE] addrmgr: Properly scale up. #1132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit c80c8e7 was supposed to mimic Bitcoin Core commit 1d21ba2f5ecbf03086d0b65c4c4c80a39a94c2ee in order to implement the suggested Countermeasure 6 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015. However, erroneously the triedBucketSize was increased instead of the triedBucketCount. This commit fixes this error in order to properly mimic the Bitcoin Core commit referenced above. This change in isolation is problematic, because after applying it old peers.json files will still load, but with many empty new tried buckets and potentially overfull old tried buckets. See issue decred#1131 for discussion.
|
Any status updates on this? It's been a while and I'd either like to get it finalized or close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c80c8e7 was supposed to mimic
Bitcoin Core commit bitcoin/bitcoin@1d21ba2 in order to implement the suggested Countermeasure 6 in
Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan
Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive
Report 2015/263. March 2015.
However, erroneously the
triedBucketSizewas increased instead of thetriedBucketCount.This commit fixes this error in order to properly mimic the Bitcoin Core
commit referenced above.
This change in isolation is problematic, because after applying it old
peers.json files will still load, but with many empty new tried buckets and
potentially overfull old tried buckets.
See issue #1131 for discussion.