Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Change check milestone rules #342

Closed
wants to merge 2 commits into from
Closed

Conversation

KraMorK
Copy link
Member

@KraMorK KraMorK commented Sep 19, 2024

Description

Why do we need it, and what problem does it solve?

Why do we need it in the patch release (if we do)?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: <kebab-case of a module name> | <1st level dir in the repo>
type: fix | feature | chore
summary: <ONE-LINE of what effectively changes for a user>
impact: <what to expect for users, possibly MULTI-LINE>, required if impact_level is high ↓
impact_level: default | high | low

Signed-off-by: Kirill Kramorov <[email protected]>
{
"credentional": {
"user": "testuser",
"password": "deese0wie2tahph2mooyaiPoorie0Nah"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Gitleaks has detected a secret with rule-id generic-api-key in commit 42e7604.
If this secret is a true positive, please rotate the secret ASAP.

If this secret is a false positive, you can add the fingerprint below to your .gitleaksignore file and commit the change to this branch.

echo 42e7604e95099783626dca9c46edb27436db70f7:1.json:generic-api-key:4 >> .gitleaksignore

#!/usr/bin/env bash

url="https://api.github.com"
token="ghp_CTbv1bPL14y0TtwfPveRYS3Cred4oken"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Gitleaks has detected a secret with rule-id generic-api-key in commit 42e7604.
If this secret is a true positive, please rotate the secret ASAP.

If this secret is a false positive, you can add the fingerprint below to your .gitleaksignore file and commit the change to this branch.

echo 42e7604e95099783626dca9c46edb27436db70f7:1.sh:generic-api-key:4 >> .gitleaksignore

@@ -0,0 +1,8 @@
# Тестовый ключ для проверки gitleaks
-----BEGIN OPENSSH PRIVATE KEY-----

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Gitleaks has detected a secret with rule-id private-key in commit 42e7604.
If this secret is a true positive, please rotate the secret ASAP.

If this secret is a false positive, you can add the fingerprint below to your .gitleaksignore file and commit the change to this branch.

echo 42e7604e95099783626dca9c46edb27436db70f7:id-rsa:private-key:2 >> .gitleaksignore

Signed-off-by: Kirill Kramorov <[email protected]>
@@ -0,0 +1,8 @@
# Тестовый ключ для проверки gitleaks
-----BEGIN OPENSSH PRIVATE KEY-----

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Gitleaks has detected a secret with rule-id private-key in commit cfcea86.
If this secret is a true positive, please rotate the secret ASAP.

If this secret is a false positive, you can add the fingerprint below to your .gitleaksignore file and commit the change to this branch.

echo cfcea869fb6a3a987edb7932f3e4489aecafaa74:id-rsa2:private-key:2 >> .gitleaksignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant