Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply suggestions from code review #338

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

KraMorK
Copy link
Member

@KraMorK KraMorK commented Sep 18, 2024

Description

Why do we need it, and what problem does it solve?

Why do we need it in the patch release (if we do)?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: <kebab-case of a module name> | <1st level dir in the repo>
type: fix | feature | chore
summary: <ONE-LINE of what effectively changes for a user>
impact: <what to expect for users, possibly MULTI-LINE>, required if impact_level is high ↓
impact_level: default | high | low

Co-authored-by: Nikolay Mitrofanov <[email protected]>
Signed-off-by: Kirill Kramorov <[email protected]>
@KraMorK KraMorK added e2e/run/aws e2e/use/multimaster Use three master for e2e test labels Sep 18, 2024
@KraMorK KraMorK merged commit 887a4ab into main Sep 18, 2024
36 of 38 checks passed
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Sep 18, 2024

🔴 e2e: AWS for deckhouse:feat/add-multimaster-e2e-tests failed in 1m20s.

Workflow details (1 job failed)

🔴 e2e: AWS, Containerd, Kubernetes 1.27 failed in 12s.

@KraMorK KraMorK deleted the feat/add-multimaster-e2e-tests branch September 18, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e/cluster/failed e2e/use/multimaster Use three master for e2e test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants