Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test vectors #273

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Update test vectors #273

merged 4 commits into from
Jul 10, 2023

Conversation

BasileiosKal
Copy link
Contributor

@BasileiosKal BasileiosKal commented Jul 2, 2023 •
edited
Loading

Test vectors for #267 and #268.

Breaking changes from the PRs

  1. From Error handling #267

    • hash_to_scalar: removed count. There is no longer a loop and the input to expand_message is just msg_octets instead of msg_prime = msg_octets || I2OSP(count, 8)
    • creat_generators: removed n (and the check at step 8) and went from I2OSP(n, 4) to I2OSP(i, 8) in the input to expand_message when calculating v.

  2. From Message to Scalar flexibility #268

    • ciphersuite_id: added HM2S_ at the end (the MAP_TO_SCALAR_ID of the map_to_scalar operation).

@BasileiosKal
Copy link
Contributor Author

Note that the test vectors use variable length messages now (with one of the messages being empty). Addresses one of the comments in #223.

@BasileiosKal BasileiosKal mentioned this pull request Jul 3, 2023
Merged
@christianpaquin christianpaquin mentioned this pull request Jul 7, 2023
Merged
@BasileiosKal
Copy link
Contributor Author

Discussed on the WG call of the 10th of July. Fixtures are cross validated. Mergin

@BasileiosKal BasileiosKal merged commit 380b454 into main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BasileiosKal