Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroy stream to prevent leaking file descriptors #1812

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

pentreathm
Copy link
Member

Description

Please include a summary of the change and which issue is fixed/closed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Closes # (issue)

Changes

Specify the behavior changes introduced by this pull request

i.e.

  • Removed method X from class Y
  • Return 400 instead of 500 in Z case
  • Refactored class X into a new module

Types of changes

What types of changes does your code introduce? Remove the lines that don't that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change). If there's an API change, link the pull request in the API spec repository and the accepted DAO governance poll
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pentreathm pentreathm merged commit fe67a84 into main Oct 1, 2024
5 checks passed
@pentreathm pentreathm deleted the file-descriptors branch October 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants