Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LW improvements and fixes #3193

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

LautaroPetaccio
Copy link
Contributor

This PR improves the LW publishing flow by:

  • Showing the user the item's mapping when confirming the items to be published.
  • Changing the payment sagas to have separated phases, that is, waiting for the transaction to be accepted, processing the transaction and publishing items and changes. This implies a more ordered flow for the users.

And fixes:

  • The publishing flow crashing due to lack of retries on the publishing API calls.
  • The missing third party publishing status function when wrapping the publishing modal with the withAuthorization wrapper.
  • The auto-sizing of the MappingEditor component, which was missing the min-width property.
  • The edit name icon in the ThirdPartyCollectionDetail page being pushed to the right so much it wasn't visible.
  • Removes the capability to change the third party collection name after publishing it.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 8:00pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11076896518

Details

  • 53 of 54 (98.15%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 48.839%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/collection/selectors.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/modules/thirdParty/utils.ts 1 75.38%
Totals Coverage Status
Change from base Build 11038264511: 0.2%
Covered Lines: 5861
Relevant Lines: 11037

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 8a01e00 into master Sep 27, 2024
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/lw-flow-improvements branch September 27, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants