Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add pets #30

Merged
merged 22 commits into from
Aug 6, 2024
Merged

Feat/add pets #30

merged 22 commits into from
Aug 6, 2024

Conversation

Gaffomdz
Copy link
Collaborator

@Gaffomdz Gaffomdz commented Aug 2, 2024

Pets functionality added

Gaffomdz added 17 commits July 3, 2024 14:32
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
1d2fee4
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
2334c40
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
052f585
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
08b0494
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
c7099fd
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
a1382af
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
b83673b
@Gaffomdz
feat: autoBattle, DesertDungeon and MinersCave added
e8e3867
@Gaffomdz
fix: pigs and chicken attack fix
3a768a3
@Gaffomdz
prettier
2cb95f7
@Gaffomdz
fix: butcher removeEntity update
d9a1fc4
@Gaffomdz
prettier
6bd87a4
@Gaffomdz
feat: added correct values for dungeons
18ee4c4
@Gaffomdz
Added pet functionality
413aa73
@Gaffomdz
Merge branch 'main' of https://github.com/decentraland-scenes/Antrom-RPG
2e70403
@Gaffomdz
Update package.json
599380c
@Gaffomdz
Merge branch 'main' into feat/add-pets
dacce99
@leanmendoza leanmendoza changed the base branch from main to feat/add-dungeons-functionality August 2, 2024 10:43
@leanmendoza leanmendoza changed the base branch from feat/add-dungeons-functionality to main August 2, 2024 10:43
@leanmendoza leanmendoza mentioned this pull request Aug 5, 2024
Closed
leanmendoza
leanmendoza requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good!
Some minor changes related to dead code and typings

scene/src/controllers/realm.controller.ts Show resolved Hide resolved
scene/src/enemies/monsterMeat.ts Outdated Show resolved Hide resolved
scene/src/enemies/monsterMobAuto.ts Outdated Show resolved Hide resolved
scene/src/player/petManager.ts Outdated Show resolved Hide resolved
scene/src/player/petManager.ts Outdated Show resolved Hide resolved
scene/src/player/petManager.ts Outdated Show resolved Hide resolved
scene/src/player/petManager.ts Outdated Show resolved Hide resolved
scene/src/realms/antrom.ts Outdated Show resolved Hide resolved
scene/src/realms/dungeon.ts Outdated Show resolved Hide resolved
scene/src/realms/dungeon.ts Outdated Show resolved Hide resolved
@leanmendoza leanmendoza merged commit 5245728 into main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leanmendoza leanmendoza leanmendoza requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gaffomdz @leanmendoza