add option to generate a new fingerprint file or not. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! Does this change the default behaviour and is that something we want? Since before rerunning would generate new ones right? |
ghost
requested a review
from 
The previous behavior was to always overwrite the file named debricked.fingerprints.txt. The default behavior will be the same as before (overwrite file) |
|
Please wait with merge, @sweoggy wanted to have the chance to comment on the naming convention for the new fingerprint files. |
filip-debricked
force-pushed
the
regenerate-fingerprint-file-option
branch
20 times, most recently
from
2c2a2a3 to
a638c63
Compare
filip-debricked
force-pushed
the
regenerate-fingerprint-file-option
branch
2 times, most recently
from
d4a0070 to
afb7af2
Compare
CodeScene PR Check✅ Code Health Quality Gates: OK Change in average Code Health of affected files: -0.00 (9.35 -> 9.35)
View detailed results in CodeScene 🚩 Declining Code Health (highest to lowest):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.