-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log cases where no manifest or lock files were found. Provides detail… #246
Conversation
@sweoggy Want me to add a test for the printing of strictness filter as well? Also, let me know if you have any disagreements about the PR itself as well. I find it immensely useful to improve our communication in cases where we don't find any files. Currently, nothing is printed at all in these cases, leading to confusion as to why the CLI "fails". In most cases, it's a matter of the code being filtered out by a default exclusions, but nothing is communicated to the end-user. |
I think it looks good! Test would be good |
test fails, otherwise looks good 👍 |
670e417
to
f5e861a
Compare
89ffc5f
to
18ff4ef
Compare
…s as to why no files were found.
18ff4ef
to
26200a5
Compare
CodeScene PR Check✅ Code Health Quality Gates: OK Change in average Code Health of affected files: -0.03 (9.51 -> 9.48)
View detailed results in CodeScene 🚩 Declining Code Health (highest to lowest):
|
Ghost user is me. |
…s as to why no files were found.