Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log cases where no manifest or lock files were found. Provides detail… #246

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2024

…s as to why no files were found.

@ghost ghost self-assigned this Jul 9, 2024
@ghost ghost requested a review from sweoggy July 9, 2024 13:05
@ghost
Copy link
Author

ghost commented Jul 9, 2024

@sweoggy Want me to add a test for the printing of strictness filter as well?

Also, let me know if you have any disagreements about the PR itself as well. I find it immensely useful to improve our communication in cases where we don't find any files. Currently, nothing is printed at all in these cases, leading to confusion as to why the CLI "fails". In most cases, it's a matter of the code being filtered out by a default exclusions, but nothing is communicated to the end-user.

internal/file/finder.go Outdated Show resolved Hide resolved
internal/file/finder.go Outdated Show resolved Hide resolved
@sweoggy
Copy link
Member

sweoggy commented Jul 9, 2024

@sweoggy Want me to add a test for the printing of strictness filter as well?

Also, let me know if you have any disagreements about the PR itself as well. I find it immensely useful to improve our communication in cases where we don't find any files. Currently, nothing is printed at all in these cases, leading to confusion as to why the CLI "fails". In most cases, it's a matter of the code being filtered out by a default exclusions, but nothing is communicated to the end-user.

I think it looks good! Test would be good

@ghost ghost force-pushed the log-no-files-found branch from 0405590 to 670e417 Compare July 9, 2024 15:50
@sweoggy
Copy link
Member

sweoggy commented Jul 10, 2024

test fails, otherwise looks good 👍

@ghost ghost force-pushed the log-no-files-found branch from 670e417 to f5e861a Compare July 10, 2024 11:16
@ghost ghost force-pushed the log-no-files-found branch 2 times, most recently from 89ffc5f to 18ff4ef Compare July 10, 2024 12:52
@ghost ghost force-pushed the log-no-files-found branch from 18ff4ef to 26200a5 Compare July 10, 2024 13:58
Copy link

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.03 (9.51 -> 9.48)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Complex Method groups.go: FilterGroupsByStrictness
  • Bumpy Road Ahead groups.go: FilterGroupsByStrictness

@sweoggy sweoggy merged commit 5239bff into main Jul 10, 2024
24 checks passed
@sweoggy sweoggy deleted the log-no-files-found branch July 10, 2024 14:35
@Duppils
Copy link

Duppils commented Nov 29, 2024

Ghost user is me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants