Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP resolution; fix windows lockfile format #220

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

filip-debricked
Copy link
Collaborator

@filip-debricked filip-debricked commented Apr 2, 2024

On Windows the generated lockfile sometimes contains CRLF ("\r\n") newlines. This PR fixes this by replacing the occurences with the Unix newline format.

@filip-debricked filip-debricked self-assigned this Apr 2, 2024
@filip-debricked filip-debricked force-pushed the 0-pip-parser-windows-fix branch 3 times, most recently from d4b6704 to 59c5582 Compare April 2, 2024 15:23
@filip-debricked filip-debricked force-pushed the 0-pip-parser-windows-fix branch from 59c5582 to 0ae1944 Compare April 3, 2024 07:02
Copy link

github-actions bot commented Apr 3, 2024

CodeScene PR Check

Code Health Quality Gates: OK

View detailed results in CodeScene

Copy link
Contributor

@emilwareus emilwareus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sweoggy sweoggy merged commit db811e6 into main Apr 4, 2024
19 checks passed
@sweoggy sweoggy deleted the 0-pip-parser-windows-fix branch April 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants