Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inclusion and refactor exclusion #217

Merged
merged 9 commits into from
May 2, 2024
Merged

Add inclusion and refactor exclusion #217

merged 9 commits into from
May 2, 2024

Conversation

filip-debricked
Copy link
Collaborator

No description provided.

@filip-debricked filip-debricked self-assigned this Mar 22, 2024
@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch 27 times, most recently from 99ec89b to 8118b33 Compare March 27, 2024 11:19
@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch from 411d247 to d4c6ee4 Compare March 27, 2024 14:03
sweoggy
sweoggy approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch 3 times, most recently from 0ebc925 to 07f48a3 Compare March 27, 2024 19:16
@filip-debricked filip-debricked changed the title Add minimum content lenght for fingerprinting flag Add inclusion and minimum content lenght for fingerprinting Mar 28, 2024
@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch 2 times, most recently from 0322993 to 06a2897 Compare March 28, 2024 09:06
@filip-debricked filip-debricked changed the title Add inclusion and minimum content lenght for fingerprinting Add inclusion and refactor exclusion Apr 2, 2024
@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch from 10675ff to 76a7513 Compare April 2, 2024 08:55
@sweoggy
Copy link
Member

sweoggy commented Apr 2, 2024

It has been decided that this will go into the 2.0 release instead

@sweoggy sweoggy added this to the 2.0.0 milestone Apr 2, 2024
@sweoggy
Copy link
Member

sweoggy commented Apr 5, 2024 •
edited
Loading

@filip-debricked could you please add to UPGRADE-2.0.md mentioning the behaviour change caused by this PR?

@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch from 76a7513 to 8b75757 Compare April 24, 2024 13:14
@filip-debricked filip-debricked requested a review from sweoggy April 24, 2024 14:08
@filip-debricked filip-debricked force-pushed the 0-inclusion-and-byte-flags branch 2 times, most recently from 884cee7 to dd28542 Compare May 2, 2024 11:46
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 8 findings(s) 🚩
  • Improving Code Health: 5 findings(s) ✅
  • Affected Hotspots: 6 files(s) 🔥

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Large Method scan.go: NewScanCmd 🔥
  • Large Method fingerprint_test.go: TestShouldProcessFile 🔥
  • Large Method finder_test.go: TestGetGroupsWithStrictFlag 🔥
  • Excess Number of Function Arguments strategy_factory.go: Make
  • Complex Method resolve.go: NewResolveCmd 🔥
  • Excess Number of Function Arguments strategy_mock_factory.go: Make
  • Excess Number of Function Arguments strategy_mock_factory.go: Make
  • Bumpy Road Ahead exclusion.go: Excluded 🔥

✅ Improving Code Health:

  • Primitive Obsession fingerprint.go 🔥
  • String Heavy Function Arguments fingerprint.go 🔥
  • Primitive Obsession resolver.go
  • Complex Method fingerprint.go: FingerprintFiles 🔥
  • Bumpy Road Ahead fingerprint.go: FingerprintFiles 🔥

@sweoggy sweoggy merged commit f2817e9 into main May 2, 2024
19 checks passed
@sweoggy sweoggy deleted the 0-inclusion-and-byte-flags branch May 2, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweoggy sweoggy sweoggy approved these changes

Assignees

@filip-debricked filip-debricked

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@filip-debricked @sweoggy