Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version hint flag #213

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Version hint flag #213

merged 6 commits into from
Mar 21, 2024

Conversation

filip-debricked
Copy link
Collaborator

No description provided.

@filip-debricked filip-debricked self-assigned this Mar 11, 2024
@filip-debricked filip-debricked marked this pull request as draft March 11, 2024 09:29
@filip-debricked filip-debricked changed the title 6837 version hint consolidation flag Version hint consolidation flag Mar 11, 2024
@filip-debricked filip-debricked requested a review from ProgHaj March 11, 2024 09:52
@filip-debricked filip-debricked changed the title Version hint consolidation flag Version hint flag Mar 11, 2024
@filip-debricked filip-debricked marked this pull request as ready for review March 11, 2024 13:39
@filip-debricked filip-debricked force-pushed the 6837-version-hint-consolidation-flag branch from 11fc5d0 to 123032c Compare March 11, 2024 13:40
Copy link
Collaborator

@ProgHaj ProgHaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@filip-debricked filip-debricked force-pushed the 6837-version-hint-consolidation-flag branch from 4260fe6 to bee87e2 Compare March 13, 2024 13:27
Copy link

CodeScene PR Check


View detailed results in CodeScene

Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 1 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 1 files(s) 🔥

🚩 Declining Code Health (highest to lowest):

  • Large Method scan.go: NewScanCmd 🔥

@sweoggy sweoggy merged commit 2d07f2e into main Mar 21, 2024
19 checks passed
@sweoggy sweoggy deleted the 6837-version-hint-consolidation-flag branch March 21, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants