Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Call Graph #206

Merged
merged 21 commits into from
Apr 4, 2024
Merged

Go Call Graph #206

merged 21 commits into from
Apr 4, 2024

Conversation

emilwareus
Copy link
Contributor

No description provided.

@emilwareus emilwareus marked this pull request as draft March 1, 2024 16:16
@emilwareus emilwareus self-assigned this Mar 11, 2024
@emilwareus emilwareus marked this pull request as ready for review March 11, 2024 15:26
@emilwareus emilwareus requested a review from ProgHaj March 11, 2024 15:26
filip-debricked
filip-debricked reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great, really nice refactoring as well! Some small naming things I think we should fix before merge but great work!

internal/callgraph/finder/golangfinder/finder.go Outdated Show resolved Hide resolved
internal/callgraph/language/golang/stategy.go Outdated Show resolved Hide resolved
internal/callgraph/model/model.go Outdated Show resolved Hide resolved
internal/callgraph/model/model.go Outdated Show resolved Hide resolved
internal/callgraph/language/golang/callgraph.go Outdated Show resolved Hide resolved
@filip-debricked filip-debricked force-pushed the additional-cg branch 2 times, most recently from a8cd5c1 to 4d6a800 Compare April 4, 2024 13:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 10 findings(s) 🚩
  • Improving Code Health: 5 findings(s) ✅

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Code Duplication job_test.go
  • Complex Method finder.go: FindFiles
  • Complex Conditional finder.go: FindFiles
  • Complex Method finder.go: FindFiles
  • Complex Conditional callgraph.go: mainPackages
  • Excess Number of Function Arguments callgraph.go: NewCallgraphBuilder
  • Excess Number of Function Arguments job.go: NewJob
  • Excess Number of Function Arguments strategy.go: NewStrategy
  • Excess Number of Function Arguments model.go: AddNode
  • Bumpy Road Ahead callgraph.go: setLineStartEnd

✅ Improving Code Health:

  • Excess Number of Function Arguments strategy.go: NewStrategy
  • Complex Method finder.go: FindFiles
  • Excess Number of Function Arguments strategy_factory.go: Make
  • Excess Number of Function Arguments strategy_mock_factory.go: Make
  • Excess Number of Function Arguments strategy_mock_factory.go: Make

emilwareus added 19 commits April 4, 2024 15:20
@emilwareus @filip-debricked
restructure of callgraph code to make it easier to add more callgraphs
0b02ca8
@emilwareus @filip-debricked
initial golang callgraph implementation
0b3a42f
@emilwareus @filip-debricked
add model to call graph
d059df2
@emilwareus @filip-debricked
improve finding of golang entrypoints and add golang cg generation to…
1471c2a 
… scan command
@emilwareus @filip-debricked
fix call lines
189c660
@emilwareus @filip-debricked
Fix error handling in GolangFinder.FindFiles() and add unit tests
bdccee2
@emilwareus @filip-debricked
Update FinderMock struct and NewStrategy function
4bda8d7
@emilwareus @filip-debricked
Add error handling in runCallGraph function and add testdata files fo…
5600b6d 
…r mocking
@emilwareus @filip-debricked
golang callgraph implementation with relying on the installed callgra…
51a0055 
…ph tool cli
@emilwareus @filip-debricked
fix job run test
809d74d
@emilwareus @filip-debricked
add tests to golang call graph
909b086
@emilwareus @filip-debricked
fixing lint errors and improve test coverage
169531a
@emilwareus @filip-debricked
Update callgraph file name in Maven tests
9076ebe
@emilwareus @filip-debricked
fix failing tests
2d5b4f9
@emilwareus @filip-debricked
fix tests and remove OS dependent test
0dd3ea8
@emilwareus @filip-debricked
Add internal/scan/testdata/npm/result.json to .gitignore
febfb73
@emilwareus @filip-debricked
Fix package name in golangfinder and file nameing
d974aef
@emilwareus @filip-debricked
Refactor callgraph struct and interface names
202ae44
@emilwareus @filip-debricked
fix callgraph construction after manual testing
29bdaba
@filip-debricked filip-debricked self-requested a review April 4, 2024 13:23
@sweoggy sweoggy merged commit 1c93113 into main Apr 4, 2024
19 checks passed
@sweoggy sweoggy deleted the additional-cg branch April 4, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filip-debricked filip-debricked filip-debricked approved these changes

@ProgHaj ProgHaj Awaiting requested review from ProgHaj

Assignees

@emilwareus emilwareus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilwareus @filip-debricked @sweoggy