Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan command writejson #193

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Scan command writejson #193

merged 11 commits into from
Feb 12, 2024

Conversation

psmf22
Copy link
Contributor

@psmf22 psmf22 commented Feb 7, 2024

added parameter --write-json to scan command
added a clause to dump the result api reply to the current working directory in result.json

Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Just had one comment

internal/scan/scanner.go Outdated Show resolved Hide resolved
@psmf22 psmf22 requested a review from sweoggy February 7, 2024 15:40
internal/scan/scanner_test.go Outdated Show resolved Hide resolved
internal/scan/scanner_test.go Outdated Show resolved Hide resolved
internal/scan/scanner.go Outdated Show resolved Hide resolved
internal/scan/scanner_test.go Outdated Show resolved Hide resolved
@psmf22 psmf22 requested a review from 4ernovm February 8, 2024 12:13
Copy link
Contributor

@4ernovm 4ernovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psmf22 , please also consider linter error. And following jobs:

are failing due to missing secrets: DEBRICKED_TOKEN and CODESCENE_DELTA_ANALYSIS_URL. I guess it should be fine when it's merged @sweoggy

internal/scan/scanner_test.go Outdated Show resolved Hide resolved
@psmf22
Copy link
Contributor Author

psmf22 commented Feb 9, 2024

The lint error is fixed but the test is failing because of an unexpected character in the output. Since I copied the basic test structure from the TestScan method that is probably affected as well. Can i just adjust the assertions or is that something that should be looked into?

@4ernovm
Copy link
Contributor

4ernovm commented Feb 9, 2024

The lint error is fixed but the test is failing because of an unexpected character in the output. Since I copied the basic test structure from the TestScan method that is probably affected as well. Can i just adjust the assertions or is that something that should be looked into?

really weird case. but this test case is passing if I remove package.json from assertion here https://github.com/debricked/cli/pull/193/files#diff-c62bf37f4ed4361740b06f5208e8da365648689558611632638a3280868a45c8R179

otherwise LGTM

@sweoggy sweoggy merged commit 4199e21 into debricked:main Feb 12, 2024
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants