-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan command writejson #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Just had one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psmf22 , please also consider linter error. And following jobs:
- https://github.com/debricked/cli/actions/runs/7829390617/job/21368232360?pr=193
- https://github.com/debricked/cli/actions/runs/7829390629/job/21368232412?pr=193
are failing due to missing secrets: DEBRICKED_TOKEN and CODESCENE_DELTA_ANALYSIS_URL. I guess it should be fine when it's merged @sweoggy
Co-authored-by: Michael Chernov <[email protected]>
The lint error is fixed but the test is failing because of an unexpected character in the output. Since I copied the basic test structure from the TestScan method that is probably affected as well. Can i just adjust the assertions or is that something that should be looked into? |
really weird case. but this test case is passing if I remove otherwise LGTM |
added parameter --write-json to scan command
added a clause to dump the result api reply to the current working directory in result.json