Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composer.json resolver #151

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Add composer.json resolver #151

merged 4 commits into from
Nov 23, 2023

Conversation

4ernovm
Copy link
Contributor

@4ernovm 4ernovm commented Nov 22, 2023

No description provided.

@emilwareus
Copy link
Contributor

Well done! Looks great! I just have one more important question in the comments

@sweoggy sweoggy changed the title Add composer files resolver Add composer.json resolver Nov 22, 2023
sweoggy
sweoggy approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@4ernovm 4ernovm force-pushed the composer-files-resolution branch from f978405 to 1ec1c87 Compare November 23, 2023 11:06
@github-actions GitHub Actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

@sweoggy sweoggy merged commit 8b6def9 into main Nov 23, 2023
25 checks passed
@sweoggy sweoggy deleted the composer-files-resolution branch November 23, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilwareus emilwareus emilwareus approved these changes

@sweoggy sweoggy sweoggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4ernovm @emilwareus @sweoggy