Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint contents of .jar and .nupkg #147

Merged
merged 10 commits into from
Nov 10, 2023
Merged

Fingerprint contents of .jar and .nupkg #147

merged 10 commits into from
Nov 10, 2023

Conversation

emilwareus
Copy link
Contributor

No description provided.

@emilwareus emilwareus self-assigned this Nov 7, 2023
@emilwareus emilwareus marked this pull request as draft November 7, 2023 11:43
@github-actions GitHub Actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 2 findings(s) 🚩
Improving Code Health 1 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

🚩 Declining Code Health (highest to lowest):

  • Large Method fingerprint_test.go: TestShouldProcessFile
  • Primitive Obsession fingerprint.go

✅ Improving Code Health:

  • Complex Method fingerprint_test.go: TestShouldProcessFile

@emilwareus emilwareus requested a review from sweoggy November 10, 2023 07:08
@emilwareus emilwareus marked this pull request as ready for review November 10, 2023 08:34
sweoggy
sweoggy approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@sweoggy sweoggy merged commit c61a9a5 into main Nov 10, 2023
19 checks passed
@sweoggy sweoggy deleted the unpack-files-to-fingerprint branch November 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zozs zozs zozs left review comments

@sweoggy sweoggy sweoggy approved these changes

Assignees

@emilwareus emilwareus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilwareus @zozs @sweoggy