Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type instead of cat on windows #142

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Use type instead of cat on windows #142

merged 4 commits into from
Nov 1, 2023

Conversation

sweoggy
Copy link
Member

@sweoggy sweoggy commented Oct 31, 2023

No description provided.

@sweoggy sweoggy requested a review from emilwareus October 31, 2023 14:10
@sweoggy sweoggy self-assigned this Oct 31, 2023
@sweoggy sweoggy force-pushed the use-type-instead-of-cat-on-windows branch from 6558bef to a31ef1f Compare October 31, 2023 14:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

emilwareus
emilwareus approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@emilwareus emilwareus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Now resolution works on my windows-🧱

internal/runtime/os/os.go Show resolved Hide resolved
@sweoggy sweoggy merged commit c42365b into main Nov 1, 2023
19 checks passed
@sweoggy sweoggy deleted the use-type-instead-of-cat-on-windows branch November 1, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilwareus emilwareus emilwareus approved these changes

Assignees

@sweoggy sweoggy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweoggy @emilwareus